Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ca1cef3a authored by Jiri Slaby's avatar Jiri Slaby Committed by David S. Miller
Browse files

NET: bna, fix lock imbalance 



bnad_set_rx_mode omit to unlock bna_lock on one fail path. Fix that.

Signed-off-by: default avatarJiri Slaby <jslaby@suse.cz>
Cc: Debashis Dutt <ddutt@brocade.com>
Cc: Rasesh Mody <rmody@brocade.com>
Cc: David S. Miller <davem@davemloft.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e8f7f43a

drivers/net/bna/bnad.c

+2 −1
Original line number Diff line number Diff line
@@ -2702,7 +2702,7 @@ bnad_set_rx_mode(struct net_device *netdev) 
			kzalloc((mc_count + 1) * ETH_ALEN,

				GFP_ATOMIC);

		if (!mcaddr_list)

			return;

			goto unlock;



		memcpy(&mcaddr_list[0], &bnad_bcast_addr[0], ETH_ALEN);
@@ -2715,6 +2715,7 @@ bnad_set_rx_mode(struct net_device *netdev) 
		/* Should we enable BNAD_CF_ALLMULTI for err != 0 ? */

		kfree(mcaddr_list);

	}

unlock:

	spin_unlock_irqrestore(&bnad->bna_lock, flags);

}