Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ca047e71 authored by Julia Lawall's avatar Julia Lawall Committed by Michal Marek
Browse files

coccinelle: ifnullfree: various cleanups 



Adjust tests to compare against NULL, to match cases that explicitly make
that comparison.

Remove removal and re-addition of freeing functions.

Add position variable on usb_free_urb in the non-patch case.

Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarMichal Marek <mmarek@suse.cz>
parent 41167d07

scripts/coccinelle/free/ifnullfree.cocci

+7 −11
Original line number Diff line number Diff line
@@ -16,19 +16,15 @@ virtual context 
@r2 depends on patch@

expression E;

@@

- if (E)

- if (E != NULL)

(

-	kfree(E);

+ kfree(E);

  kfree(E);

|

-	debugfs_remove(E);

+ debugfs_remove(E);

  debugfs_remove(E);

|

-	debugfs_remove_recursive(E);

+ debugfs_remove_recursive(E);

  debugfs_remove_recursive(E);

|

-	usb_free_urb(E);

+ usb_free_urb(E);

  usb_free_urb(E);

)



@r depends on context || report || org @
@@ -36,8 +32,8 @@ expression E; 
position p;

@@



* if (E)

*	\(kfree@p\|debugfs_remove@p\|debugfs_remove_recursive@p\|usb_free_urb\)(E);

* if (E != NULL)

*	\(kfree@p\|debugfs_remove@p\|debugfs_remove_recursive@p\|usb_free_urb@p\)(E);



@script:python depends on org@

p << r.p;