Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ca0141de authored by Rob Herring's avatar Rob Herring Committed by Thomas Gleixner
Browse files

gpu/drm: Kill off set_irq_flags usage 



set_irq_flags is ARM specific with custom flags which have genirq
equivalents. Convert drivers to use the genirq interfaces directly, so we
can kill off set_irq_flags. The translation of flags is as follows:

IRQF_VALID -> !IRQ_NOREQUEST
IRQF_PROBE -> !IRQ_NOPROBE
IRQF_NOAUTOEN -> IRQ_NOAUTOEN

For IRQs managed by an irqdomain, the irqdomain core code handles clearing
and setting IRQ_NOREQUEST already, so there is no need to do this in
.map() functions and we can simply remove the set_irq_flags calls. Some
users also modify IRQ_NOPROBE and this has been maintained although it
is not clear that is really needed. There appears to be a great deal of
blind copy and paste of this code.

Signed-off-by: default avatarRob Herring <robh@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org
Cc: Russell King <linux@arm.linux.org.uk>
Cc: David Airlie <airlied@linux.ie>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
parent bd0b9ac4

drivers/gpu/drm/msm/mdp/mdp5/mdp5_irq.c

+0 −1
Original line number Diff line number Diff line
@@ -178,7 +178,6 @@ static int mdp5_hw_irqdomain_map(struct irq_domain *d, 


	irq_set_chip_and_handler(irq, &mdp5_hw_irq_chip, handle_level_irq);

	irq_set_chip_data(irq, mdp5_kms);

	set_irq_flags(irq, IRQF_VALID);



	return 0;

}

drivers/gpu/ipu-v3/ipu-common.c

+1 −2
Original line number Diff line number Diff line
@@ -1099,8 +1099,7 @@ static int ipu_irq_init(struct ipu_soc *ipu) 
	}



	ret = irq_alloc_domain_generic_chips(ipu->domain, 32, 1, "IPU",

					     handle_level_irq, 0,

					     IRQF_VALID, 0);

					     handle_level_irq, 0, 0, 0);

	if (ret < 0) {

		dev_err(ipu->dev, "failed to alloc generic irq chips\n");

		irq_domain_remove(ipu->domain);