Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c8448051 authored by Wei Yongjun's avatar Wei Yongjun Committed by Mark Brown
Browse files

ASoC: sirf-audio-codec: Fix return value check in sirf_audio_codec_driver_probe() 



In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().

Signed-off-by: default avatarWei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: default avatarMark Brown <broonie@linaro.org>
parent 9779caf9

sound/soc/codecs/sirf-audio-codec.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -471,8 +471,8 @@ static int sirf_audio_codec_driver_probe(struct platform_device *pdev) 




	mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

	mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

	base = devm_ioremap_resource(&pdev->dev, mem_res);

	base = devm_ioremap_resource(&pdev->dev, mem_res);

	if (base == NULL)

	if (IS_ERR(base))

		return -ENOMEM;

		return PTR_ERR(base);





	sirf_audio_codec->regmap = devm_regmap_init_mmio(&pdev->dev, base,

	sirf_audio_codec->regmap = devm_regmap_init_mmio(&pdev->dev, base,

					    &sirf_audio_codec_regmap_config);

					    &sirf_audio_codec_regmap_config);