Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c7e62def authored by Kulikov Vasiliy's avatar Kulikov Vasiliy Committed by Greg Kroah-Hartman
Browse files

staging: adis16255: fix sysfs leak



Original code does not call sysfs_remove_group() on error. This can lead
to NULL dereference.

Signed-off-by: default avatarKulikov Vasiliy <segooon@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent cd6541c0
Loading
Loading
Loading
Loading
+3 −1
Original line number Diff line number Diff line
@@ -406,12 +406,14 @@ static int __devinit spi_adis16255_probe(struct spi_device *spi)

	status = spi_adis16255_bringup(spiadis);
	if (status != 0)
		goto irq_err;
		goto sysfs_err;

	dev_info(&spi->dev, "spi_adis16255 driver added!\n");

	return status;

sysfs_err:
	sysfs_remove_group(&spiadis->spi->dev.kobj, &adis16255_attr_group);
irq_err:
	free_irq(spiadis->irq, spiadis);
gpio_err: