Commit c7e163fe authored Oct 07, 2016 by Ethan Hsieh Committed by Marcel Holtmann Oct 07, 2016

Bluetooth: btusb: Fix atheros firmware download error



Move usb_autopm_get_interface() ahead of setup_on_usb() to prevent
device from sending usb control message in usb suspend mode.

The error message is as below:

[   83.944103] btusb 1-2:1.1: usb_suspend_interface: status 0
[   83.944107] btusb 1-2:1.0: usb_suspend_interface: status 0
[   83.960132] usb 1-2: usb auto-suspend, wakeup 0
[   83.976156] usb 1-2: usb_suspend_device: status 0
[   83.976162] usb 1-2: usb_suspend_both: status 0
[  298.689106] Bluetooth: hci0
[  298.689399] Bluetooth: hci0: Failed to access otp area (-113)

Signed-off-by: Ethan Hsieh <ethan.hsieh@canonical.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

parent 1b422066

drivers/bluetooth/btusb.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -1043,6 +1043,10 @@ static int btusb_open(struct hci_dev *hdev)

		BT_DBG("%s", hdev->name);

		err = usb_autopm_get_interface(data->intf);
		if (err < 0)
		return err;

		/* Patching USB firmware files prior to starting any URBs of HCI path
		* It is more safe to use USB bulk channel for downloading USB patch
		*/
		@@ -1052,10 +1056,6 @@ static int btusb_open(struct hci_dev *hdev)
		return err;
		}

		err = usb_autopm_get_interface(data->intf);
		if (err < 0)
		return err;

		data->intf->needs_remote_wakeup = 1;

		if (test_and_set_bit(BTUSB_INTR_RUNNING, &data->flags))