Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c7a29e56 authored by Stefan Weinhuber's avatar Stefan Weinhuber Committed by Martin Schwidefsky
Browse files

[S390] dasd: check sense type in device change handler 



When evaluating sense data in dasd_eckd_check_for_device_change, we
must always check for the type of sense data in byte 27, bit 0, to
make sure that the rest of the sense data is interpreted correctly.

Signed-off-by: default avatarStefan Weinhuber <wein@de.ibm.com>
Signed-off-by: default avatarMartin Schwidefsky <schwidefsky@de.ibm.com>
parent e35c76cd

drivers/s390/block/dasd_eckd.c

+3 −2
Original line number Diff line number Diff line
@@ -2037,7 +2037,7 @@ static void dasd_eckd_check_for_device_change(struct dasd_device *device, 
		return;



	/* summary unit check */

	if ((sense[7] == 0x0D) &&

	if ((sense[27] & DASD_SENSE_BIT_0) && (sense[7] == 0x0D) &&

	    (scsw_dstat(&irb->scsw) & DEV_STAT_UNIT_CHECK)) {

		dasd_alias_handle_summary_unit_check(device, irb);

		return;
@@ -2053,7 +2053,8 @@ static void dasd_eckd_check_for_device_change(struct dasd_device *device, 
	/* loss of device reservation is handled via base devices only

	 * as alias devices may be used with several bases

	 */

	if (device->block && (sense[7] == 0x3F) &&

	if (device->block && (sense[27] & DASD_SENSE_BIT_0) &&

	    (sense[7] == 0x3F) &&

	    (scsw_dstat(&irb->scsw) & DEV_STAT_UNIT_CHECK) &&

	    test_bit(DASD_FLAG_IS_RESERVED, &device->flags)) {

		if (device->features & DASD_FEATURE_FAILONSLCK)