Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c7805e54 authored by Maciej S. Szmigiero's avatar Maciej S. Szmigiero Committed by Darren Hart
Browse files

hp-wmi: fix unregister order in hp_wmi_rfkill_setup() once again 



rfkill registration order in hp_wmi_rfkill_setup() is:
1) WiFi,
2) BT,
3) WWAN,
5) GPS.

Unregistration when cleaning up on error return should happen in reverse
order.

This means that: If BT rfkill fails to be allocated we possibly need to
first unregister WiFi rfkill before destroying it.

The same goes with (WWAN, BT) and (GPS, WWAN) pairs.

Also, if WWAN rfkill fails to register we need to (possibly) unregister BT
not the GPS one.  And if GPS rfkill fails to register we need to unregister
WWAN not the BT one.

We never need to unregister GPS rfkill here since if GPS rfkill
registration succeeds this function returns without error so no cleanup is
necessary.

Signed-off-by: default avatarMaciej S. Szmigiero <mail@maciej.szmigiero.name>
Signed-off-by: default avatarDarren Hart <dvhart@linux.intel.com>
parent aaf3a5e7

drivers/platform/x86/hp-wmi.c

+7 −7
Original line number Diff line number Diff line
@@ -746,7 +746,7 @@ static int __init hp_wmi_rfkill_setup(struct platform_device *device) 
						(void *) HPWMI_BLUETOOTH);

		if (!bluetooth_rfkill) {

			err = -ENOMEM;

			goto register_wifi_error;

			goto register_bluetooth_error;

		}

		rfkill_init_sw_state(bluetooth_rfkill,

				     hp_wmi_get_sw_state(HPWMI_BLUETOOTH));
@@ -764,7 +764,7 @@ static int __init hp_wmi_rfkill_setup(struct platform_device *device) 
					   (void *) HPWMI_WWAN);

		if (!wwan_rfkill) {

			err = -ENOMEM;

			goto register_bluetooth_error;

			goto register_wwan_error;

		}

		rfkill_init_sw_state(wwan_rfkill,

				     hp_wmi_get_sw_state(HPWMI_WWAN));
@@ -782,7 +782,7 @@ static int __init hp_wmi_rfkill_setup(struct platform_device *device) 
						(void *) HPWMI_GPS);

		if (!gps_rfkill) {

			err = -ENOMEM;

			goto register_wwan_error;

			goto register_gps_error;

		}

		rfkill_init_sw_state(gps_rfkill,

				     hp_wmi_get_sw_state(HPWMI_GPS));
@@ -797,13 +797,13 @@ static int __init hp_wmi_rfkill_setup(struct platform_device *device) 
register_gps_error:

	rfkill_destroy(gps_rfkill);

	gps_rfkill = NULL;

	if (bluetooth_rfkill)

		rfkill_unregister(bluetooth_rfkill);

	if (wwan_rfkill)

		rfkill_unregister(wwan_rfkill);

register_wwan_error:

	rfkill_destroy(wwan_rfkill);

	wwan_rfkill = NULL;

	if (gps_rfkill)

		rfkill_unregister(gps_rfkill);

	if (bluetooth_rfkill)

		rfkill_unregister(bluetooth_rfkill);

register_bluetooth_error:

	rfkill_destroy(bluetooth_rfkill);

	bluetooth_rfkill = NULL;