Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c6f77bc2 authored by Geert Uytterhoeven's avatar Geert Uytterhoeven Committed by Lee Jones
Browse files

backlight: 88pm860x_bl: Use of_get_child_by_name() instead of refcount hack 



of_find_node_by_name() calls of_node_put() on its "from" parameter.
To counter this, pm860x_backlight_dt_init() calls of_node_get() first.

Use of_get_child_by_name() instead to get rid of the refcount hack.

Signed-off-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
parent 9eccca08

drivers/video/backlight/88pm860x_bl.c

+1 −4
Original line number Diff line number Diff line
@@ -168,10 +168,7 @@ static int pm860x_backlight_dt_init(struct platform_device *pdev, 
	struct device_node *nproot, *np;

	int iset = 0;



	nproot = of_node_get(pdev->dev.parent->of_node);

	if (!nproot)

		return -ENODEV;

	nproot = of_find_node_by_name(nproot, "backlights");

	nproot = of_get_child_by_name(pdev->dev.parent->of_node, "backlights");

	if (!nproot) {

		dev_err(&pdev->dev, "failed to find backlights node\n");

		return -ENODEV;