Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c6f1495d authored by Ville Syrjälä's avatar Ville Syrjälä Committed by Daniel Vetter
Browse files

drm/i915: Allow HDMI+HDMI cloning on g4x 

BSpec is a bit unclear whether HDMI+HDMI cloning should work on g4x.
Tests on real hardware say that it does. Since g4x can't send
infoframes to more than one HDMI port anyway, we don't lose anything
by allow it.

For PCH platforms BSpec explicitly forbids HDMI+HDMI cloning.

Whether HDMI+HDMI cloning might also work on VLV is a bit unclear, but
since we'd at least lose the capability of sending infoframes to more
than one cloned HDMI port, it doesn't seem like a good idea to allow it.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=73850


Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: default avatarRodrigo Vivi <rodrigo.vivi@gmail.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent 301ea74a

drivers/gpu/drm/i915/intel_hdmi.c

+7 −0
Original line number Diff line number Diff line
@@ -1344,6 +1344,13 @@ void intel_hdmi_init(struct drm_device *dev, int hdmi_reg, enum port port) 
	intel_encoder->type = INTEL_OUTPUT_HDMI;

	intel_encoder->crtc_mask = (1 << 0) | (1 << 1) | (1 << 2);

	intel_encoder->cloneable = 1 << INTEL_OUTPUT_ANALOG;

	/*

	 * BSpec is unclear about HDMI+HDMI cloning on g4x, but it seems

	 * to work on real hardware. And since g4x can send infoframes to

	 * only one port anyway, nothing is lost by allowing it.

	 */

	if (IS_G4X(dev))

		intel_encoder->cloneable |= 1 << INTEL_OUTPUT_HDMI;



	intel_dig_port->port = port;

	intel_dig_port->hdmi.hdmi_reg = hdmi_reg;