Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c5d55248 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Herbert Xu
Browse files

lib/mpi: avoid assembler warning



A wrapper around the umull assembly instruction might reuse
the input register as an output, which is undefined on
some ARM machines, as pointed out by this assembler warning:

  CC      lib/mpi/generic_mpih-mul1.o
/tmp/ccxJuxIy.s: Assembler messages:
/tmp/ccxJuxIy.s:53: rdhi, rdlo and rm must all be different
  CC      lib/mpi/generic_mpih-mul2.o
/tmp/ccI0scAD.s: Assembler messages:
/tmp/ccI0scAD.s:53: rdhi, rdlo and rm must all be different
  CC      lib/mpi/generic_mpih-mul3.o
/tmp/ccMvVQcp.s: Assembler messages:
/tmp/ccMvVQcp.s:53: rdhi, rdlo and rm must all be different

This changes the constraints to force different registers to
be used as output.

Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 1879f40a
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -216,7 +216,7 @@ extern UDItype __udiv_qrnnd(UDItype *, UDItype, UDItype, UDItype);
	__asm__ ("%@ Inlined umul_ppmm\n" \
		"umull %r1, %r0, %r2, %r3" \
	: "=&r" ((USItype)(xh)), \
			"=r" ((USItype)(xl)) \
			"=&r" ((USItype)(xl)) \
	: "r" ((USItype)(a)), \
			"r" ((USItype)(b)) \
	: "r0", "r1")