Commit c5857e3f authored Mar 06, 2016 by Vladimir Zapolskiy Committed by Thierry Reding Mar 23, 2016

pwm: brcmstb: Fix check of devm_ioremap_resource() return code



The change fixes potential oops while accessing iomem on invalid address
if devm_ioremap_resource() fails due to some reason.

The devm_ioremap_resource() function returns ERR_PTR() and never returns
NULL, which makes useless a following check for NULL.

Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
Fixes: 3a9f5957 ("pwm: Add Broadcom BCM7038 PWM controller support")
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>

parent 03d99531

drivers/pwm/pwm-brcmstb.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -274,8 +274,8 @@ static int brcmstb_pwm_probe(struct platform_device *pdev)

		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
		p->base = devm_ioremap_resource(&pdev->dev, res);
		if (!p->base) {
		ret = -ENOMEM;
		if (IS_ERR(p->base)) {
		ret = PTR_ERR(p->base);
		goto out_clk;
		}