Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c57baf1e authored by Eric W. Biederman's avatar Eric W. Biederman Committed by Ingo Molnar
Browse files

sched: fix sysctl directory permissions 



There are two remaining gotchas:

- The directories have impossible permissions (writeable).

- The ctl_name for the kernel directory is inconsistent with
  everything else.  It should be CTL_KERN.

Signed-off-by: default avatarEric W. Biederman <ebiederm@xmission.com>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent 2aa44d05

kernel/sched.c

+5 −4
Original line number Diff line number Diff line
@@ -5257,15 +5257,16 @@ static void migrate_dead_tasks(unsigned int dead_cpu) 
static struct ctl_table sd_ctl_dir[] = {

	{

		.procname	= "sched_domain",

		.mode		= 0755,

		.mode		= 0555,

	},

	{0,},

};



static struct ctl_table sd_ctl_root[] = {

	{

		.ctl_name	= CTL_KERN,

		.procname	= "kernel",

		.mode		= 0755,

		.mode		= 0555,

		.child		= sd_ctl_dir,

	},

	{0,},
@@ -5341,7 +5342,7 @@ static ctl_table *sd_alloc_ctl_cpu_table(int cpu) 
	for_each_domain(cpu, sd) {

		snprintf(buf, 32, "domain%d", i);

		entry->procname = kstrdup(buf, GFP_KERNEL);

		entry->mode = 0755;

		entry->mode = 0555;

		entry->child = sd_alloc_ctl_domain_table(sd);

		entry++;

		i++;
@@ -5361,7 +5362,7 @@ static void init_sched_domain_sysctl(void) 
	for (i = 0; i < cpu_num; i++, entry++) {

		snprintf(buf, 32, "cpu%d", i);

		entry->procname = kstrdup(buf, GFP_KERNEL);

		entry->mode = 0755;

		entry->mode = 0555;

		entry->child = sd_alloc_ctl_cpu_table(i);

	}

	sd_sysctl_header = register_sysctl_table(sd_ctl_root);