Commit c56c81ab authored Apr 08, 2009 by Dan Williams

dmatest: fix max channels handling



The check for reaching max_channels is short circuited by 'continuing'
after successfully adding a channel.

[ Impact: make the 'max_channels' module parameter actually have an effect ]

Cc: <stable@kernel.org>
Reported-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>

parent 577c9c45

drivers/dma/dmatest.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -531,9 +531,7 @@ static int __init dmatest_init(void)
		chan = dma_request_channel(mask, filter, NULL);
		if (chan) {
		err = dmatest_add_channel(chan);
		if (err == 0)
		continue;
		else {
		if (err) {
		dma_release_channel(chan);
		break; /* add_channel failed, punt */
		}