Commit c4cf0935 authored Nov 10, 2014 by Keerthy Committed by Tony Lindgren Nov 12, 2014

bus: omap_l3_noc: Correct returning IRQ_HANDLED unconditionally in the irq handler



Correct returning IRQ_HANDLED unconditionally in the irq handler.
Return IRQ_NONE for some interrupt which we do not expect to be
handled in this handler. This prevents kernel stalling with back
to back spurious interrupts.

Fixes: 2722e56d ("OMAP4: l3: Introduce l3-interconnect error handling driver")
Acked-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Keerthy <j-keerthy@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>

parent 61b43d4e

drivers/bus/omap_l3_noc.c

+6 −2

Original line number	Diff line number	Diff line
		@@ -222,10 +222,14 @@ static irqreturn_t l3_interrupt_handler(int irq, void *_l3)
		}

		/* Error found so break the for loop */
		break;
		return IRQ_HANDLED;
		}
		}
		return IRQ_HANDLED;

		dev_err(l3->dev, "L3 %s IRQ not handled!!\n",
		inttype ? "debug" : "application");

		return IRQ_NONE;
		}

		static const struct of_device_id l3_noc_match[] = {