Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c2d340a4 authored by Laurent Pinchart's avatar Laurent Pinchart Committed by Paul Mundt
Browse files

gxt4500: use display information in info not in var for panning 



We must not use any information in the passed var besides xoffset,
yoffset and vmode as otherwise applications might abuse it.

Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Paul Mackerras <paulus@samba.org>
Signed-off-by: default avatarPaul Mundt <lethal@linux-sh.org>
parent c12665ff

drivers/video/gxt4500.c

+2 −2
Original line number Diff line number Diff line
@@ -543,8 +543,8 @@ static int gxt4500_pan_display(struct fb_var_screeninfo *var, 


	if (var->xoffset & 7)

		return -EINVAL;

	if (var->xoffset + var->xres > var->xres_virtual ||

	    var->yoffset + var->yres > var->yres_virtual)

	if (var->xoffset + info->var.xres > info->var.xres_virtual ||

	    var->yoffset + info->var.yres > info->var.yres_virtual)

		return -EINVAL;



	writereg(par, REFRESH_START, (var->xoffset << 16) | var->yoffset);