Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c26d85cb authored by Axel Lin's avatar Axel Lin Committed by Matthew Garrett
Browse files

asus-laptop: fix wapf, wlan_status and bluetooth_status module_param permissions 



The wapf module parameters defines the behavior of the Fn+Fx wlan key.
The wlan_status and bluetooth_status module parameters are for setting the
wlan/bluetooth status on boot.

All above module parameters are determinated only at the module load time.
 Change the value after the module is loaded does not make sense and has
no effect at all, thus set the permissions to 0444 instead of 0644.

Signed-off-by: default avatarAxel Lin <axel.lin@gmail.com>
Cc: Corentin Chary <corentincj@iksaif.net>
Cc: Matthew Garrett <mjg@redhat.com>
Cc: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarMatthew Garrett <mjg@redhat.com>
parent ff2367d1

drivers/platform/x86/asus-laptop.c

+3 −3
Original line number Diff line number Diff line
@@ -76,18 +76,18 @@ MODULE_LICENSE("GPL"); 
 * So, if something doesn't work as you want, just try other values =)

 */

static uint wapf = 1;

module_param(wapf, uint, 0644);

module_param(wapf, uint, 0444);

MODULE_PARM_DESC(wapf, "WAPF value");



static int wlan_status = 1;

static int bluetooth_status = 1;



module_param(wlan_status, int, 0644);

module_param(wlan_status, int, 0444);

MODULE_PARM_DESC(wlan_status, "Set the wireless status on boot "

		 "(0 = disabled, 1 = enabled, -1 = don't do anything). "

		 "default is 1");



module_param(bluetooth_status, int, 0644);

module_param(bluetooth_status, int, 0444);

MODULE_PARM_DESC(bluetooth_status, "Set the wireless status on boot "

		 "(0 = disabled, 1 = enabled, -1 = don't do anything). "

		 "default is 1");