Commit c259ae52 authored Jul 21, 2008 by Julia Lawall Committed by Mark Fasheh Jul 31, 2008

[PATCH] ocfs2: Release mutex in error handling code

The mutex is released on a successful return, so it would seem that it
should be released on an error return as well.

The semantic patch finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/

)

// <smpl>
@@
expression l;
@@

mutex_lock(l);
... when != mutex_unlock(l)
    when any
    when strict
(
if (...) { ... when != mutex_unlock(l)
+   mutex_unlock(l);
    return ...;
}
|
mutex_unlock(l);
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Mark Fasheh <mfasheh@suse.com>

parent 961cecbe

fs/ocfs2/file.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1766,8 +1766,8 @@ static int __ocfs2_change_file_space(struct file file, struct inode inode,
		out_rw_unlock:
		ocfs2_rw_unlock(inode, 1);

		mutex_unlock(&inode->i_mutex);
		out:
		mutex_unlock(&inode->i_mutex);
		return ret;
		}