Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c16ce190 authored by Josef Bacik's avatar Josef Bacik Committed by Chris Mason
Browse files

Btrfs: remove all BUG_ON()'s from commit_cowonly_roots 



Noticed this when forcing errors to happen during delayed ref running.  Thanks,

Signed-off-by: default avatarJosef Bacik <jbacik@fusionio.com>
Signed-off-by: default avatarChris Mason <chris.mason@fusionio.com>
parent 1de2cfde

fs/btrfs/transaction.c

+8 −5
Original line number Diff line number Diff line
@@ -950,16 +950,19 @@ static noinline int commit_cowonly_roots(struct btrfs_trans_handle *trans, 
		return ret;



	ret = btrfs_run_dev_stats(trans, root->fs_info);

	WARN_ON(ret);

	if (ret)

		return ret;

	ret = btrfs_run_dev_replace(trans, root->fs_info);

	WARN_ON(ret);



	if (ret)

		return ret;

	ret = btrfs_run_qgroups(trans, root->fs_info);

	BUG_ON(ret);

	if (ret)

		return ret;



	/* run_qgroups might have added some more refs */

	ret = btrfs_run_delayed_refs(trans, root, (unsigned long)-1);

	BUG_ON(ret);

	if (ret)

		return ret;



	while (!list_empty(&fs_info->dirty_cowonly_roots)) {

		next = fs_info->dirty_cowonly_roots.next;