Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c1085b10 authored by Emil Tantilov's avatar Emil Tantilov Committed by Jeff Kirsher
Browse files

ixgbe: fix incorrect PHY register reads 



Fix some register reads that had the opcode and register parameters swapped.
Also use define instead of a magic (0x3) number.

Signed-off-by: default avatarEmil Tantilov <emil.s.tantilov@intel.com>
Tested-by: default avatarPhil Schmitt <phillip.j.schmitt@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent f83396ad

drivers/net/ethernet/intel/ixgbe/ixgbe_common.c

+4 −4
Original line number Diff line number Diff line
@@ -266,10 +266,10 @@ s32 ixgbe_clear_hw_cntrs_generic(struct ixgbe_hw *hw) 
	if (hw->mac.type == ixgbe_mac_X540) {

		if (hw->phy.id == 0)

			hw->phy.ops.identify(hw);

		hw->phy.ops.read_reg(hw, 0x3, IXGBE_PCRC8ECL, &i);

		hw->phy.ops.read_reg(hw, 0x3, IXGBE_PCRC8ECH, &i);

		hw->phy.ops.read_reg(hw, 0x3, IXGBE_LDPCECL, &i);

		hw->phy.ops.read_reg(hw, 0x3, IXGBE_LDPCECH, &i);

		hw->phy.ops.read_reg(hw, IXGBE_PCRC8ECL, MDIO_MMD_PCS, &i);

		hw->phy.ops.read_reg(hw, IXGBE_PCRC8ECH, MDIO_MMD_PCS, &i);

		hw->phy.ops.read_reg(hw, IXGBE_LDPCECL, MDIO_MMD_PCS, &i);

		hw->phy.ops.read_reg(hw, IXGBE_LDPCECH, MDIO_MMD_PCS, &i);

	}



	return 0;