Commit c0d246b8 authored Oct 20, 2012 by Jiri Olsa Committed by Arnaldo Carvalho de Melo Dec 09, 2012

perf hists: Fix period symbol_conf.field_sep display



Currently we don't properly display hist data with symbol_conf.field_sep
separator. We need to display either space or separator.

Signed-off-by: Jiri Olsa <jolsa@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: http://lkml.kernel.org/n/tip-cyggwys0bz5kqdowwvfd8h72@git.kernel.org


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent 1240005e

tools/perf/ui/hist.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -472,11 +472,15 @@ int hist_entry__period_snprintf(struct perf_hpp hpp, struct hist_entry he,
		return 0;

		perf_hpp__for_each_format(fmt) {
		/*
		* If there's no field_sep, we still need
		* to display initial ' '.
		*/
		if (!sep \|\| !first) {
		ret = scnprintf(hpp->buf, hpp->size, "%s", sep ?: " ");
		advance_hpp(hpp, ret);
		} else
		first = false;
		}

		if (color && fmt->color)
		ret = fmt->color(hpp, he);