Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c098284a authored by Lars-Peter Clausen's avatar Lars-Peter Clausen Committed by Mark Brown
Browse files

ASoC: intel: Don't set unused struct snd_pcm_hardware fields 



The ASoC core assumes that the PCM component of the ASoC card transparently
moves data around and does not impose any restrictions on the memory layout or
the transfer speed. It ignores all fields from the snd_pcm_hardware struct for
the PCM driver that are related to this. Setting these fields in the PCM driver
might suggest otherwise though, so rather not set them.

Signed-off-by: default avatarLars-Peter Clausen <lars@metafoo.de>
Signed-off-by: default avatarMark Brown <broonie@linaro.org>
parent 784cbf8a

sound/soc/intel/sst_platform.c

+0 −10
Original line number Diff line number Diff line
@@ -89,16 +89,6 @@ static struct snd_pcm_hardware sst_platform_pcm_hw = { 
			SNDRV_PCM_INFO_MMAP_VALID |

			SNDRV_PCM_INFO_BLOCK_TRANSFER |

			SNDRV_PCM_INFO_SYNC_START),

	.formats = (SNDRV_PCM_FMTBIT_S16 | SNDRV_PCM_FMTBIT_U16 |

			SNDRV_PCM_FMTBIT_S24 | SNDRV_PCM_FMTBIT_U24 |

			SNDRV_PCM_FMTBIT_S32 | SNDRV_PCM_FMTBIT_U32),

	.rates = (SNDRV_PCM_RATE_8000|

			SNDRV_PCM_RATE_44100 |

			SNDRV_PCM_RATE_48000),

	.rate_min = SST_MIN_RATE,

	.rate_max = SST_MAX_RATE,

	.channels_min =	SST_MIN_CHANNEL,

	.channels_max =	SST_MAX_CHANNEL,

	.buffer_bytes_max = SST_MAX_BUFFER,

	.period_bytes_min = SST_MIN_PERIOD_BYTES,

	.period_bytes_max = SST_MAX_PERIOD_BYTES,

sound/soc/intel/sst_platform.h

+0 −4
Original line number Diff line number Diff line
@@ -33,10 +33,6 @@ 
#define SST_STEREO		2

#define SST_MAX_CAP		5



#define SST_MIN_RATE		8000

#define SST_MAX_RATE		48000

#define SST_MIN_CHANNEL		1

#define SST_MAX_CHANNEL		5

#define SST_MAX_BUFFER		(800*1024)

#define SST_MIN_BUFFER		(800*1024)

#define SST_MIN_PERIOD_BYTES	32