Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bf283707 authored by Mark Brown's avatar Mark Brown Committed by Dmitry Torokhov
Browse files

Input: wm831x-ts - move BTN_TOUCH reporting to data transfer 



Don't report BTN_TOUCH until we've got data as some less robust applications
can be confused by getting a touch event by itself and it doesn't seem
unreasonable for them to expect coordinates along with a touch.

Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: default avatarDmitry Torokhov <dtor@mail.ru>
parent acad9853

drivers/input/touchscreen/wm831x-ts.c

+2 −3
Original line number Diff line number Diff line
@@ -148,6 +148,8 @@ static irqreturn_t wm831x_ts_data_irq(int irq, void *irq_data) 
		input_report_key(wm831x_ts->input_dev, BTN_TOUCH, 0);



		schedule_work(&wm831x_ts->pd_data_work);

	} else {

		input_report_key(wm831x_ts->input_dev, BTN_TOUCH, 1);

	}



	input_sync(wm831x_ts->input_dev);
@@ -174,9 +176,6 @@ static irqreturn_t wm831x_ts_pen_down_irq(int irq, void *irq_data) 
			WM831X_TCH_X_ENA | WM831X_TCH_Y_ENA | WM831X_TCH_Z_ENA,

			WM831X_TCH_X_ENA | WM831X_TCH_Y_ENA | ena);



	input_report_key(wm831x_ts->input_dev, BTN_TOUCH, 1);

	input_sync(wm831x_ts->input_dev);



	wm831x_set_bits(wm831x, WM831X_INTERRUPT_STATUS_1,

			WM831X_TCHPD_EINT, WM831X_TCHPD_EINT);