Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bcc98a46 authored by H Hartley Sweeten's avatar H Hartley Sweeten Committed by David Woodhouse
Browse files

mtd: fix different address space noise 



In mtd_ioctl MEMGETREGIONINFO the region_user_info pointer ur
is cast in __kernel space. This produces a number of sparse warnings
like:

warning: cast removes address space of expression
warning: incorrect type in initializer (different address spaces)
   expected unsigned int const [noderef] <asn:1>*register __p
   got unsigned int *<noident>

Since argp is already a void __user * just use it dirrectly without
the cast and make ur a __user *.

Signed-off-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: default avatarArtem Bityutskiy <Artem.Bityutskiy@nokia.com>
Signed-off-by: default avatarDavid Woodhouse <David.Woodhouse@intel.com>
parent 1449c5d0

drivers/mtd/mtdchar.c

+1 −1
Original line number Diff line number Diff line
@@ -482,7 +482,7 @@ static int mtd_ioctl(struct inode *inode, struct file *file, 
	{

		uint32_t ur_idx;

		struct mtd_erase_region_info *kr;

		struct region_info_user *ur = (struct region_info_user *) argp;

		struct region_info_user __user *ur = argp;



		if (get_user(ur_idx, &(ur->regionindex)))

			return -EFAULT;