Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bcbb8c9c authored by Johannes Berg's avatar Johannes Berg Committed by Emmanuel Grumbach
Browse files

iwlwifi: pcie: move warning message into warning 



Having a WARN_ON() followed by a printed message is
less useful than having the message in the warning
so move the message.

Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
Signed-off-by: default avatarEmmanuel Grumbach <emmanuel.grumbach@intel.com>
parent 22cba0c0

drivers/net/wireless/iwlwifi/pcie/tx.c

+4 −5
Original line number Diff line number Diff line
@@ -1495,12 +1495,11 @@ static int iwl_pcie_send_hcmd_sync(struct iwl_trans *trans, 
	IWL_DEBUG_INFO(trans, "Attempting to send sync command %s\n",

		       get_cmd_string(trans_pcie, cmd->id));



	if (WARN_ON(test_and_set_bit(STATUS_HCMD_ACTIVE,

				     &trans_pcie->status))) {

		IWL_ERR(trans, "Command %s: a command is already active!\n",

			get_cmd_string(trans_pcie, cmd->id));

	if (WARN(test_and_set_bit(STATUS_HCMD_ACTIVE,

				  &trans_pcie->status),

		 "Command %s: a command is already active!\n",

		 get_cmd_string(trans_pcie, cmd->id)))

		return -EIO;

	}



	IWL_DEBUG_INFO(trans, "Setting HCMD_ACTIVE for command %s\n",

		       get_cmd_string(trans_pcie, cmd->id));