Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bc034ef5 authored by Stephan Mueller's avatar Stephan Mueller Committed by Herbert Xu
Browse files

crypto: drbg - remove unnecessary sanity checks 



The drbg_make_shadow function contains sanity checks which are not
needed as the function is invoked at times where it is ensured that the
checked-for variables are available.

Signed-off-by: default avatarStephan Mueller <smueller@chronox.de>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent e6c0244a

crypto/drbg.c

+0 −9
Original line number Diff line number Diff line
@@ -1263,15 +1263,6 @@ static int drbg_make_shadow(struct drbg_state *drbg, struct drbg_state **shadow) 
	int ret = -ENOMEM;

	struct drbg_state *tmp = NULL;



	if (!drbg || !drbg->core || !drbg->V || !drbg->C) {

		pr_devel("DRBG: attempt to generate shadow copy for "

			 "uninitialized DRBG state rejected\n");

		return -EINVAL;

	}

	/* HMAC does not have a scratchpad */

	if (!(drbg->core->flags & DRBG_HMAC) && NULL == drbg->scratchpad)

		return -EINVAL;



	tmp = kzalloc(sizeof(struct drbg_state), GFP_KERNEL);

	if (!tmp)

		return -ENOMEM;