Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bbed297d authored by Charles Keepax's avatar Charles Keepax Committed by Mark Brown
Browse files

ASoC: wm8804: Split out bus drivers 



Simplify dependencies by using new style split out bus interfaces.

Signed-off-by: default avatarCharles Keepax <ckeepax@opensource.wolfsonmicro.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent c517d838

sound/soc/codecs/Kconfig

+15 −3
Original line number Diff line number Diff line
@@ -141,7 +141,8 @@ config SND_SOC_ALL_CODECS 
	select SND_SOC_WM8770 if SPI_MASTER

	select SND_SOC_WM8776 if SND_SOC_I2C_AND_SPI

	select SND_SOC_WM8782

	select SND_SOC_WM8804 if SND_SOC_I2C_AND_SPI

	select SND_SOC_WM8804_I2C if I2C

	select SND_SOC_WM8804_SPI if SPI_MASTER

	select SND_SOC_WM8900 if I2C

	select SND_SOC_WM8903 if I2C

	select SND_SOC_WM8904 if I2C
@@ -744,8 +745,19 @@ config SND_SOC_WM8782 
	tristate



config SND_SOC_WM8804

	tristate "Wolfson Microelectronics WM8804 S/PDIF transceiver"

	depends on SND_SOC_I2C_AND_SPI

	tristate



config SND_SOC_WM8804_I2C

	tristate "Wolfson Microelectronics WM8804 S/PDIF transceiver I2C"

	depends on I2C

	select SND_SOC_WM8804

	select REGMAP_I2C



config SND_SOC_WM8804_SPI

	tristate "Wolfson Microelectronics WM8804 S/PDIF transceiver SPI"

	depends on SPI_MASTER

	select SND_SOC_WM8804

	select REGMAP_SPI



config SND_SOC_WM8900

	tristate

sound/soc/codecs/Makefile

+4 −0
Original line number Diff line number Diff line
@@ -145,6 +145,8 @@ snd-soc-wm8770-objs := wm8770.o 
snd-soc-wm8776-objs := wm8776.o

snd-soc-wm8782-objs := wm8782.o

snd-soc-wm8804-objs := wm8804.o

snd-soc-wm8804-i2c-objs := wm8804-i2c.o

snd-soc-wm8804-spi-objs := wm8804-spi.o

snd-soc-wm8900-objs := wm8900.o

snd-soc-wm8903-objs := wm8903.o

snd-soc-wm8904-objs := wm8904.o
@@ -323,6 +325,8 @@ obj-$(CONFIG_SND_SOC_WM8770) += snd-soc-wm8770.o 
obj-$(CONFIG_SND_SOC_WM8776)	+= snd-soc-wm8776.o

obj-$(CONFIG_SND_SOC_WM8782)	+= snd-soc-wm8782.o

obj-$(CONFIG_SND_SOC_WM8804)	+= snd-soc-wm8804.o

obj-$(CONFIG_SND_SOC_WM8804_I2C) += snd-soc-wm8804-i2c.o

obj-$(CONFIG_SND_SOC_WM8804_SPI) += snd-soc-wm8804-spi.o

obj-$(CONFIG_SND_SOC_WM8900)	+= snd-soc-wm8900.o

obj-$(CONFIG_SND_SOC_WM8903)	+= snd-soc-wm8903.o

obj-$(CONFIG_SND_SOC_WM8904)	+= snd-soc-wm8904.o

sound/soc/codecs/wm8804-i2c.c

0 → 100644
+64 −0
Original line number Diff line number Diff line 
/*

 * wm8804-i2c.c  --  WM8804 S/PDIF transceiver driver - I2C

 *

 * Copyright 2015 Cirrus Logic Inc

 *

 * Author: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>

 *

 * This program is free software; you can redistribute it and/or modify

 * it under the terms of the GNU General Public License version 2 as

 * published by the Free Software Foundation.

 */



#include <linux/init.h>

#include <linux/module.h>

#include <linux/i2c.h>



#include "wm8804.h"



static int wm8804_i2c_probe(struct i2c_client *i2c,

			    const struct i2c_device_id *id)

{

	struct regmap *regmap;



	regmap = devm_regmap_init_i2c(i2c, &wm8804_regmap_config);

	if (IS_ERR(regmap))

		return PTR_ERR(regmap);



	return wm8804_probe(&i2c->dev, regmap);

}



static int wm8804_i2c_remove(struct i2c_client *i2c)

{

	wm8804_remove(&i2c->dev);

	return 0;

}



static const struct i2c_device_id wm8804_i2c_id[] = {

	{ "wm8804", 0 },

	{ }

};

MODULE_DEVICE_TABLE(i2c, wm8804_i2c_id);



static const struct of_device_id wm8804_of_match[] = {

	{ .compatible = "wlf,wm8804", },

	{ }

};

MODULE_DEVICE_TABLE(of, wm8804_of_match);



static struct i2c_driver wm8804_i2c_driver = {

	.driver = {

		.name = "wm8804",

		.owner = THIS_MODULE,

		.of_match_table = wm8804_of_match,

	},

	.probe = wm8804_i2c_probe,

	.remove = wm8804_i2c_remove,

	.id_table = wm8804_i2c_id

};



module_i2c_driver(wm8804_i2c_driver);



MODULE_DESCRIPTION("ASoC WM8804 driver - I2C");

MODULE_AUTHOR("Charles Keepax <ckeepax@opensource.wolfsonmicro.com>");

MODULE_LICENSE("GPL");

sound/soc/codecs/wm8804-spi.c

0 → 100644
+56 −0
Original line number Diff line number Diff line 
/*

 * wm8804-spi.c  --  WM8804 S/PDIF transceiver driver - SPI

 *

 * Copyright 2015 Cirrus Logic Inc

 *

 * Author: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>

 *

 * This program is free software; you can redistribute it and/or modify

 * it under the terms of the GNU General Public License version 2 as

 * published by the Free Software Foundation.

 */



#include <linux/init.h>

#include <linux/module.h>

#include <linux/spi/spi.h>



#include "wm8804.h"



static int wm8804_spi_probe(struct spi_device *spi)

{

	struct regmap *regmap;



	regmap = devm_regmap_init_spi(spi, &wm8804_regmap_config);

	if (IS_ERR(regmap))

		return PTR_ERR(regmap);



	return wm8804_probe(&spi->dev, regmap);

}



static int wm8804_spi_remove(struct spi_device *spi)

{

	wm8804_remove(&spi->dev);

	return 0;

}



static const struct of_device_id wm8804_of_match[] = {

	{ .compatible = "wlf,wm8804", },

	{ }

};

MODULE_DEVICE_TABLE(of, wm8804_of_match);



static struct spi_driver wm8804_spi_driver = {

	.driver = {

		.name = "wm8804",

		.owner = THIS_MODULE,

		.of_match_table = wm8804_of_match,

	},

	.probe = wm8804_spi_probe,

	.remove = wm8804_spi_remove

};



module_spi_driver(wm8804_spi_driver);



MODULE_DESCRIPTION("ASoC WM8804 driver - SPI");

MODULE_AUTHOR("Charles Keepax <ckeepax@opensource.wolfsonmicro.com>");

MODULE_LICENSE("GPL");

sound/soc/codecs/wm8804.c

+16 −123
Original line number Diff line number Diff line
@@ -15,10 +15,7 @@ 
#include <linux/init.h>

#include <linux/delay.h>

#include <linux/pm.h>

#include <linux/i2c.h>

#include <linux/of_device.h>

#include <linux/spi/spi.h>

#include <linux/regmap.h>

#include <linux/regulator/consumer.h>

#include <linux/slab.h>

#include <sound/core.h>
@@ -518,7 +515,7 @@ static int wm8804_set_bias_level(struct snd_soc_codec *codec, 
	return 0;

}



static int wm8804_remove(struct snd_soc_codec *codec)

static int wm8804_codec_remove(struct snd_soc_codec *codec)

{

	struct wm8804_priv *wm8804;

	int i;
@@ -531,7 +528,7 @@ static int wm8804_remove(struct snd_soc_codec *codec) 
	return 0;

}



static int wm8804_probe(struct snd_soc_codec *codec)

static int wm8804_codec_probe(struct snd_soc_codec *codec)

{

	struct wm8804_priv *wm8804;

	int i, id1, id2, ret;
@@ -649,8 +646,8 @@ static struct snd_soc_dai_driver wm8804_dai = { 
};



static const struct snd_soc_codec_driver soc_codec_dev_wm8804 = {

	.probe = wm8804_probe,

	.remove = wm8804_remove,

	.probe = wm8804_codec_probe,

	.remove = wm8804_codec_remove,

	.set_bias_level = wm8804_set_bias_level,

	.idle_bias_off = true,
@@ -658,13 +655,7 @@ static const struct snd_soc_codec_driver soc_codec_dev_wm8804 = { 
	.num_controls = ARRAY_SIZE(wm8804_snd_controls),

};



static const struct of_device_id wm8804_of_match[] = {

	{ .compatible = "wlf,wm8804", },

	{ }

};

MODULE_DEVICE_TABLE(of, wm8804_of_match);



static const struct regmap_config wm8804_regmap_config = {

const struct regmap_config wm8804_regmap_config = {

	.reg_bits = 8,

	.val_bits = 8,
@@ -675,128 +666,30 @@ static const struct regmap_config wm8804_regmap_config = { 
	.reg_defaults = wm8804_reg_defaults,

	.num_reg_defaults = ARRAY_SIZE(wm8804_reg_defaults),

};

EXPORT_SYMBOL_GPL(wm8804_regmap_config);



#if defined(CONFIG_SPI_MASTER)

static int wm8804_spi_probe(struct spi_device *spi)

int wm8804_probe(struct device *dev, struct regmap *regmap)

{

	struct wm8804_priv *wm8804;

	int ret;



	wm8804 = devm_kzalloc(&spi->dev, sizeof *wm8804, GFP_KERNEL);

	wm8804 = devm_kzalloc(dev, sizeof(*wm8804), GFP_KERNEL);

	if (!wm8804)

		return -ENOMEM;



	wm8804->regmap = devm_regmap_init_spi(spi, &wm8804_regmap_config);

	if (IS_ERR(wm8804->regmap)) {

		ret = PTR_ERR(wm8804->regmap);

		return ret;

	}



	spi_set_drvdata(spi, wm8804);

	dev_set_drvdata(dev, wm8804);



	ret = snd_soc_register_codec(&spi->dev,

				     &soc_codec_dev_wm8804, &wm8804_dai, 1);

	wm8804->regmap = regmap;



	return ret;

}



static int wm8804_spi_remove(struct spi_device *spi)

{

	snd_soc_unregister_codec(&spi->dev);

	return 0;

	return snd_soc_register_codec(dev, &soc_codec_dev_wm8804,

				      &wm8804_dai, 1);

}

EXPORT_SYMBOL_GPL(wm8804_probe);



static struct spi_driver wm8804_spi_driver = {

	.driver = {

		.name = "wm8804",

		.owner = THIS_MODULE,

		.of_match_table = wm8804_of_match,

	},

	.probe = wm8804_spi_probe,

	.remove = wm8804_spi_remove

};

#endif



#if IS_ENABLED(CONFIG_I2C)

static int wm8804_i2c_probe(struct i2c_client *i2c,

			    const struct i2c_device_id *id)

void wm8804_remove(struct device *dev)

{

	struct wm8804_priv *wm8804;

	int ret;



	wm8804 = devm_kzalloc(&i2c->dev, sizeof *wm8804, GFP_KERNEL);

	if (!wm8804)

		return -ENOMEM;



	wm8804->regmap = devm_regmap_init_i2c(i2c, &wm8804_regmap_config);

	if (IS_ERR(wm8804->regmap)) {

		ret = PTR_ERR(wm8804->regmap);

		return ret;

	snd_soc_unregister_codec(dev);

}



	i2c_set_clientdata(i2c, wm8804);



	ret = snd_soc_register_codec(&i2c->dev,

				     &soc_codec_dev_wm8804, &wm8804_dai, 1);

	return ret;

}



static int wm8804_i2c_remove(struct i2c_client *i2c)

{

	snd_soc_unregister_codec(&i2c->dev);

	return 0;

}



static const struct i2c_device_id wm8804_i2c_id[] = {

	{ "wm8804", 0 },

	{ }

};

MODULE_DEVICE_TABLE(i2c, wm8804_i2c_id);



static struct i2c_driver wm8804_i2c_driver = {

	.driver = {

		.name = "wm8804",

		.owner = THIS_MODULE,

		.of_match_table = wm8804_of_match,

	},

	.probe = wm8804_i2c_probe,

	.remove = wm8804_i2c_remove,

	.id_table = wm8804_i2c_id

};

#endif



static int __init wm8804_modinit(void)

{

	int ret = 0;



#if IS_ENABLED(CONFIG_I2C)

	ret = i2c_add_driver(&wm8804_i2c_driver);

	if (ret) {

		printk(KERN_ERR "Failed to register wm8804 I2C driver: %d\n",

		       ret);

	}

#endif

#if defined(CONFIG_SPI_MASTER)

	ret = spi_register_driver(&wm8804_spi_driver);

	if (ret != 0) {

		printk(KERN_ERR "Failed to register wm8804 SPI driver: %d\n",

		       ret);

	}

#endif

	return ret;

}

module_init(wm8804_modinit);



static void __exit wm8804_exit(void)

{

#if IS_ENABLED(CONFIG_I2C)

	i2c_del_driver(&wm8804_i2c_driver);

#endif

#if defined(CONFIG_SPI_MASTER)

	spi_unregister_driver(&wm8804_spi_driver);

#endif

}

module_exit(wm8804_exit);

EXPORT_SYMBOL_GPL(wm8804_remove);



MODULE_DESCRIPTION("ASoC WM8804 driver");

MODULE_AUTHOR("Dimitris Papastamos <dp@opensource.wolfsonmicro.com>");