Commit bba57f8f authored Sep 04, 2015 by Sudip Mukherjee Committed by Greg Kroah-Hartman Sep 20, 2015

drivers/misc/sgi-gru: fix dereference of ERR_PTR



gru_alloc_gts() can fail and it can return ERR_PTR(errvalue). We should
not dereference it if it has returned error. And incase it has returned
error then wait for some time and try again.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Acked-by: Dimitri Sivanich <sivanich@sgi.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent c2ed545c

drivers/misc/sgi-gru/grukservices.c

+6 −1

Original line number	Diff line number	Diff line
		@@ -160,7 +160,12 @@ static void gru_load_kernel_context(struct gru_blade_state *bs, int blade_id)
		down_write(&bs->bs_kgts_sema);

		if (!bs->bs_kgts) {
		do {
		bs->bs_kgts = gru_alloc_gts(NULL, 0, 0, 0, 0, 0);
		if (!IS_ERR(bs->bs_kgts))
		break;
		msleep(1);
		} while (true);
		bs->bs_kgts->ts_user_blade_id = blade_id;
		}
		kgts = bs->bs_kgts;