Commit bb55b327 authored Sep 22, 2008 by Julia Lawall Committed by David S. Miller Sep 22, 2008

drivers/net/wan: Use DIV_ROUND_UP

The kernel.h macro DIV_ROUND_UP performs the computation (((n) + (d) - 1) /
(d)) but is perhaps more readable.

An extract of the semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/

)

// <smpl>
@haskernel@
@@

#include <linux/kernel.h>

@depends on haskernel@
expression n,d;
@@

(
- (n + d - 1) / d
+ DIV_ROUND_UP(n,d)
|
- (n + (d - 1)) / d
+ DIV_ROUND_UP(n,d)
)

@depends on haskernel@
expression n,d;
@@

- DIV_ROUND_UP((n),d)
+ DIV_ROUND_UP(n,d)

@depends on haskernel@
expression n,d;
@@

- DIV_ROUND_UP(n,(d))
+ DIV_ROUND_UP(n,d)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 6a19309d

drivers/net/wan/sbni.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -856,7 +856,7 @@ prepare_to_send( struct sk_buff skb, struct net_device dev )
		len = SBNI_MIN_LEN;

		nl->tx_buf_p = skb;
		nl->tx_frameno = (len + nl->maxframe - 1) / nl->maxframe;
		nl->tx_frameno = DIV_ROUND_UP(len, nl->maxframe);
		nl->framelen = len < nl->maxframe ? len : nl->maxframe;

		outb( inb( dev->base_addr + CSR0 ) \| TR_REQ, dev->base_addr + CSR0 );