Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b998e001 authored by Patrick Pannuto's avatar Patrick Pannuto Committed by Linus Torvalds
Browse files

checkpatch: fix extraneous EXPORT_SYMBOL* warnings 



These are caused by checkpatch incorrectly parsing its internal
representation of a statement block for struct's (or anything else that is
a statement block encapsulated in {}'s that also ends with a ';').  Fix
this by properly parsing a statement block.

An example:

	+struct dummy_type dummy = {
	+	.foo	= "baz",
	+};
	+EXPORT_SYMBOL_GPL(dummy);
	+
	+static int dummy_func(void)
	+{
	+	return -EDUMMYCODE;
	+}
	+EXPORT_SYMBOL_GPL(dummy_func);

	WARNING: EXPORT_SYMBOL(foo); should immediately \
		follow its function/variable
	#19: FILE: dummy.c:4:
	+EXPORT_SYMBOL_GPL(dummy);

The above warning is issued when it should not be.

Signed-off-by: default avatarPatrick Pannuto <ppannuto@codeaurora.org>
Cc: Andy Whitcroft <apw@shadowen.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 09ef8725

scripts/checkpatch.pl

+3 −0
Original line number Original line Diff line number Diff line
@@ -558,6 +558,9 @@ sub ctx_statement_block { 
			$type = ($level != 0)? '{' : '';

			$type = ($level != 0)? '{' : '';





			if ($level == 0) {

			if ($level == 0) {

				if (substr($blk, $off + 1, 1) eq ';') {

					$off++;

				}

				last;

				last;

			}

			}

		}

		}