Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b8eca77e authored by Sudip Mukherjee's avatar Sudip Mukherjee Committed by Takashi Iwai
Browse files

ALSA: ice1712: consider error value 



earlier we were ignoring the return value of snd_ak4114_create and
always returning 0.
now we are returning the actual status. revo_init is calling this
function, and revo_init is checking the return value.

Signed-off-by: default avatarSudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent b393df01

sound/pci/ice1712/revo.c

+3 −1
Original line number Original line Diff line number Diff line
@@ -494,11 +494,13 @@ static int ap192_ak4114_init(struct snd_ice1712 *ice) 
				 ap192_ak4114_write,

				 ap192_ak4114_write,

				 ak4114_init_vals, ak4114_init_txcsb,

				 ak4114_init_vals, ak4114_init_txcsb,

				 ice, &spec->ak4114);

				 ice, &spec->ak4114);

	if (err < 0)

		return err;

	/* AK4114 in Revo cannot detect external rate correctly.

	/* AK4114 in Revo cannot detect external rate correctly.

	 * No reason to stop capture stream due to incorrect checks */

	 * No reason to stop capture stream due to incorrect checks */

	spec->ak4114->check_flags = AK4114_CHECK_NO_RATE;

	spec->ak4114->check_flags = AK4114_CHECK_NO_RATE;





	return 0; /* error ignored; it's no fatal error */

	return 0;

}

}





static int revo_init(struct snd_ice1712 *ice)

static int revo_init(struct snd_ice1712 *ice)