Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b899963f authored by David Kershner's avatar David Kershner Committed by Greg Kroah-Hartman
Browse files

staging: unisys: visorbus: cleanup goto in setup_crash_devices_work_queue 



If visorbus has registered yet just reschedule and exit. The rest of
the function doesn't need to reschedule so just move it up to the
initial check.

Signed-off-by: default avatarDavid Kershner <david.kershner@unisys.com>
Signed-off-by: default avatarTimothy Sell <timothy.sell@unisys.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent dae0587e

drivers/staging/unisys/visorbus/visorchipset.c

+5 −9
Original line number Original line Diff line number Diff line
@@ -1979,8 +1979,11 @@ setup_crash_devices_work_queue(struct work_struct *work) 
	u16 local_crash_msg_count;

	u16 local_crash_msg_count;





	/* make sure visorbus is registered for controlvm callbacks */

	/* make sure visorbus is registered for controlvm callbacks */

	if (visorchipset_visorbusregwait && !visorbusregistered)

	if (visorchipset_visorbusregwait && !visorbusregistered) {

		goto cleanup;

		poll_jiffies = POLLJIFFIES_CONTROLVMCHANNEL_SLOW;

		schedule_delayed_work(&periodic_controlvm_work, poll_jiffies);

		return;

	}





	POSTCODE_LINUX_2(CRASH_DEV_ENTRY_PC, POSTCODE_SEVERITY_INFO);

	POSTCODE_LINUX_2(CRASH_DEV_ENTRY_PC, POSTCODE_SEVERITY_INFO);
@@ -2057,13 +2060,6 @@ setup_crash_devices_work_queue(struct work_struct *work) 
		return;

		return;

	}

	}

	POSTCODE_LINUX_2(CRASH_DEV_EXIT_PC, POSTCODE_SEVERITY_INFO);

	POSTCODE_LINUX_2(CRASH_DEV_EXIT_PC, POSTCODE_SEVERITY_INFO);

	return;



cleanup:



	poll_jiffies = POLLJIFFIES_CONTROLVMCHANNEL_SLOW;



	schedule_delayed_work(&periodic_controlvm_work, poll_jiffies);

}

}





static void

static void