Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b80d3942 authored by Heinrich Schuchardt's avatar Heinrich Schuchardt Committed by Daniel Vetter
Browse files

drm/mm: avoid possible null pointer dereference 



Do not dereference node before the check if node is NULL.

Signed-off-by: default avatarHeinrich Schuchardt <xypron.glpk@gmx.de>
Reviewed-by: default avatarEric Engestrom <eric.engestrom@imgtec.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/1463602639-4861-1-git-send-email-xypron.glpk@gmx.de
parent d28ab95b

drivers/gpu/drm/drm_mm.c

+3 −1
Original line number Diff line number Diff line
@@ -179,12 +179,14 @@ static void drm_mm_insert_helper(struct drm_mm_node *hole_node, 
int drm_mm_reserve_node(struct drm_mm *mm, struct drm_mm_node *node)

{

	struct drm_mm_node *hole;

	u64 end = node->start + node->size;

	u64 end;

	u64 hole_start;

	u64 hole_end;



	BUG_ON(node == NULL);



	end = node->start + node->size;



	/* Find the relevant hole to add our node to */

	drm_mm_for_each_hole(hole, mm, hole_start, hole_end) {

		if (hole_start > node->start || hole_end < end)