Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b7862742 authored by Peter Ujfalusi's avatar Peter Ujfalusi Committed by Vinod Koul
Browse files

dmaengine: edma: Fix of_device_id data parameter usage (legacy vs TPCC) 



Use pointers to static constant variables for eDMA binding
type (legacy vs TPCC).

Fixes the following warning when compiling the driver for 64bit
architectures (x86_64 for example):
drivers/dma/edma.c:2185:16: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
   if (match && (u32)match->data == EDMA_BINDING_TPCC)
                ^

Signed-off-by: default avatarPeter Ujfalusi <peter.ujfalusi@ti.com>
Signed-off-by: default avatarVinod Koul <vinod.koul@intel.com>
parent 86737510

drivers/dma/edma.c

+8 −3
Original line number Diff line number Diff line
@@ -263,14 +263,19 @@ static const struct edmacc_param dummy_paramset = { 


#define EDMA_BINDING_LEGACY	0

#define EDMA_BINDING_TPCC	1

static const u32 edma_binding_type[] = {

	[EDMA_BINDING_LEGACY] = EDMA_BINDING_LEGACY,

	[EDMA_BINDING_TPCC] = EDMA_BINDING_TPCC,

};



static const struct of_device_id edma_of_ids[] = {

	{

		.compatible = "ti,edma3",

		.data = (void *)EDMA_BINDING_LEGACY,

		.data = &edma_binding_type[EDMA_BINDING_LEGACY],

	},

	{

		.compatible = "ti,edma3-tpcc",

		.data = (void *)EDMA_BINDING_TPCC,

		.data = &edma_binding_type[EDMA_BINDING_TPCC],

	},

	{}

};
@@ -2184,7 +2189,7 @@ static int edma_probe(struct platform_device *pdev) 
		const struct of_device_id *match;



		match = of_match_node(edma_of_ids, node);

		if (match && (u32)match->data == EDMA_BINDING_TPCC)

		if (match && (*(u32 *)match->data) == EDMA_BINDING_TPCC)

			legacy_mode = false;



		info = edma_setup_info_from_dt(dev, legacy_mode);