Commit b763ec17 authored Sep 19, 2015 by Mark Brown

regmap: debugfs: Ensure we don't underflow when printing access masks



If a read is attempted which is smaller than the line length then we may
underflow the subtraction we're doing with the unsigned size_t type so
move some of the calculation to be additions on the right hand side
instead in order to avoid this.

Reported-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: Mark Brown <broonie@kernel.org>
Cc: stable@vger.kernel.org

parent 6ff33f39

drivers/base/regmap/regmap-debugfs.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -432,7 +432,7 @@ static ssize_t regmap_access_read_file(struct file *file,
		/* If we're in the region the user is trying to read */
		if (p >= *ppos) {
		/* ...but not beyond it */
		if (buf_pos >= count - 1 - tot_len)
		if (buf_pos + tot_len + 1 >= count)
		break;

		/* Format the register */