Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b7058842 authored by David S. Miller's avatar David S. Miller
Browse files

net: Make setsockopt() optlen be unsigned. 



This provides safety against negative optlen at the type
level instead of depending upon (sometimes non-trivial)
checks against this sprinkled all over the the place, in
each and every implementation.

Based upon work done by Arjan van de Ven and feedback
from Linus Torvalds.

Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent eb1cf0f8

drivers/atm/ambassador.c

+0 −8
Original line number Diff line number Diff line
@@ -1306,14 +1306,6 @@ static void amb_close (struct atm_vcc * atm_vcc) { 
  return;

}



/********** Set socket options for a VC **********/



// int amb_getsockopt (struct atm_vcc * atm_vcc, int level, int optname, void * optval, int optlen);



/********** Set socket options for a VC **********/



// int amb_setsockopt (struct atm_vcc * atm_vcc, int level, int optname, void * optval, int optlen);



/********** Send **********/



static int amb_send (struct atm_vcc * atm_vcc, struct sk_buff * skb) {

drivers/atm/eni.c

+1 −1
Original line number Diff line number Diff line
@@ -2031,7 +2031,7 @@ static int eni_getsockopt(struct atm_vcc *vcc,int level,int optname, 




static int eni_setsockopt(struct atm_vcc *vcc,int level,int optname,

    void __user *optval,int optlen)

    void __user *optval,unsigned int optlen)

{

	return -EINVAL;

}

drivers/atm/firestream.c

+1 −1
Original line number Diff line number Diff line
@@ -1244,7 +1244,7 @@ static int fs_getsockopt(struct atm_vcc *vcc,int level,int optname, 




static int fs_setsockopt(struct atm_vcc *vcc,int level,int optname,

			 void __user *optval,int optlen)

			 void __user *optval,unsigned int optlen)

{

	func_enter ();

	func_exit ();

drivers/atm/fore200e.c

+1 −1
Original line number Diff line number Diff line
@@ -1795,7 +1795,7 @@ fore200e_getsockopt(struct atm_vcc* vcc, int level, int optname, void __user *op 




static int

fore200e_setsockopt(struct atm_vcc* vcc, int level, int optname, void __user *optval, int optlen)

fore200e_setsockopt(struct atm_vcc* vcc, int level, int optname, void __user *optval, unsigned int optlen)

{

    /* struct fore200e* fore200e = FORE200E_DEV(vcc->dev); */

drivers/atm/horizon.c

+1 −1
Original line number Diff line number Diff line
@@ -2590,7 +2590,7 @@ static int hrz_getsockopt (struct atm_vcc * atm_vcc, int level, int optname, 
}



static int hrz_setsockopt (struct atm_vcc * atm_vcc, int level, int optname,

			   void *optval, int optlen) {

			   void *optval, unsigned int optlen) {

  hrz_dev * dev = HRZ_DEV(atm_vcc->dev);

  PRINTD (DBG_FLOW|DBG_VCC, "hrz_setsockopt");

  switch (level) {