Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b6b39e8f authored by Herbert Xu's avatar Herbert Xu Committed by David S. Miller
Browse files

tcp: Try to catch MSG_PEEK bug 



This patch tries to print out more information when we hit the
MSG_PEEK bug in tcp_recvmsg.  It's been around since at least
2005 and it's about time that we finally fix it.

Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 55b80503

net/ipv4/tcp.c

+3 −1
Original line number Original line Diff line number Diff line
@@ -1442,7 +1442,9 @@ int tcp_recvmsg(struct kiocb *iocb, struct sock *sk, struct msghdr *msg, 
				goto found_ok_skb;

				goto found_ok_skb;

			if (tcp_hdr(skb)->fin)

			if (tcp_hdr(skb)->fin)

				goto found_fin_ok;

				goto found_fin_ok;

			WARN_ON(!(flags & MSG_PEEK));

			if (WARN_ON(!(flags & MSG_PEEK)))

				printk(KERN_INFO "recvmsg bug 2: copied %X "

				       "seq %X\n", *seq, TCP_SKB_CB(skb)->seq);

		}

		}





		/* Well, if we have backlog, try to process it now yet. */

		/* Well, if we have backlog, try to process it now yet. */