Commit b66ecd97 authored Jul 15, 2010 by Arnaldo Carvalho de Melo

perf ui: Make ui_browser__run exit on unhandled hot keys



Right now ENTER doesn't always exits the newt tree widget, as it is used
for expanding/collapsing branches, but with the new tree widget being
developed we need to regain control to handle it, expanding/collapsing
branches.

In fact its really up to the ui_browser user to state what extra keys
should stop ui_browser__run, and it should handle just the ones needed
for basic browsing.

Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent 63f20e74

tools/perf/util/newt.c

+1 −5

Original line number	Diff line number	Diff line
		@@ -498,12 +498,8 @@ static int ui_browser__run(struct ui_browser self, struct newtExitStruct es)
		self->first_visible_entry_idx = self->index - offset;
		self->seek(self, -offset, SEEK_END);
		break;
		case NEWT_KEY_RIGHT:
		case NEWT_KEY_LEFT:
		case NEWT_KEY_TAB:
		return es->u.key;
		default:
		continue;
		return es->u.key;
		}
		if (ui_browser__refresh_entries(self) < 0)
		return -1;