Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b5f5933a authored by Dan Carpenter's avatar Dan Carpenter Committed by Mauro Carvalho Chehab
Browse files

V4L/DVB: au0828: move dereference below sanity checks 



This function has sanity checks to make sure that "dev" is non-null.  I
moved the dereference down below the checks.  In the current code "dev"
is never actually null.

Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Acked-by: default avatarDevin Heitmueller <dheitmueller@kernellabs.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 49b7a12c

drivers/media/video/au0828/au0828-video.c

+3 −1
Original line number Diff line number Diff line
@@ -441,7 +441,7 @@ static void au0828_copy_vbi(struct au0828_dev *dev, 
			      unsigned char *outp, unsigned long len)

{

	unsigned char *startwrite, *startread;

	int bytesperline = dev->vbi_width;

	int bytesperline;

	int i, j = 0;



	if (dev == NULL) {
@@ -464,6 +464,8 @@ static void au0828_copy_vbi(struct au0828_dev *dev, 
		return;

	}



	bytesperline = dev->vbi_width;



	if (dma_q->pos + len > buf->vb.size)

		len = buf->vb.size - dma_q->pos;