Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b5b60778 authored by Maurizio Lombardi's avatar Maurizio Lombardi Committed by Theodore Ts'o
Browse files

ext4: fix wrong assert in ext4_mb_normalize_request() 



The variable "size" is expressed as number of blocks and not as
number of clusters, this could trigger a kernel panic when using
ext4 with the size of a cluster different from the size of a block.

Cc: stable@vger.kernel.org
Signed-off-by: default avatarMaurizio Lombardi <mlombard@redhat.com>
Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent eeece469

fs/ext4/mballoc.c

+1 −1
Original line number Diff line number Diff line
@@ -3145,7 +3145,7 @@ ext4_mb_normalize_request(struct ext4_allocation_context *ac, 
	}

	BUG_ON(start + size <= ac->ac_o_ex.fe_logical &&

			start > ac->ac_o_ex.fe_logical);

	BUG_ON(size <= 0 || size > EXT4_CLUSTERS_PER_GROUP(ac->ac_sb));

	BUG_ON(size <= 0 || size > EXT4_BLOCKS_PER_GROUP(ac->ac_sb));



	/* now prepare goal request */