Commit b56394bf authored Mar 04, 2008 by Ray Lee Committed by Greg Kroah-Hartman Apr 24, 2008

USB: io_ti.c: remove unneeded null tty check

The Coverity checker (and Adrian Bunk) spotted an inconsistent NULL check of
port->tty (it's blindly dereferenced later without the check).

Alan Cox confirmed the check can go.

Signed-off-by: Ray Lee <ray-lk@madrabbit.org>
Cc: Adrian Bunk <bunk@kernel.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent dfa5ec79

drivers/usb/serial/io_ti.c

+1 −2

Original line number	Original line	Diff line number	Diff line
	@@ -1941,7 +1941,6 @@ static int edge_open (struct usb_serial_port port, struct file filp)
	if (edge_port == NULL)		if (edge_port == NULL)
	return -ENODEV;		return -ENODEV;

	if (port->tty)
	port->tty->low_latency = low_latency;		port->tty->low_latency = low_latency;

	port_number = port->number - port->serial->minor;		port_number = port->number - port->serial->minor;