Commit b50563a6 authored Nov 24, 2008 by Christian Lamparter Committed by John W. Linville Nov 26, 2008

p54: fix wmm queue settings



This patch fixes a regression (introduced by
"p54: more definitions form lmac_longbow.h and pda.h")

It turned out that the "ret" variable wasn't initialized and
this caused the following warnings/errors to appear:

wmaster1: failed to set TX queue parameters for queue 2
wmaster1: failed to set TX queue parameters for queue 3
wmaster1: failed to set TX queue parameters for queue 1
wmaster1: failed to set TX queue parameters for queue 0

Signed-off-by: Christian Lamparter <chunkeey@web.de>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

parent 99405f93

drivers/net/wireless/p54/p54common.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -1728,10 +1728,9 @@ static int p54_conf_tx(struct ieee80211_hw *dev, u16 queue,
		if ((params) && !(queue > 4)) {
		P54_SET_QUEUE(priv->qos_params[queue], params->aifs,
		params->cw_min, params->cw_max, params->txop);
		ret = p54_set_edcf(dev);
		} else
		ret = -EINVAL;
		if (!ret)
		ret = p54_set_edcf(dev);
		mutex_unlock(&priv->conf_mutex);
		return ret;
		}