Commit b4186971 authored Jan 11, 2013 by Laurent Pinchart Committed by Mauro Carvalho Chehab Mar 28, 2013

[media] uvcvideo: Return -EINVAL when setting a menu control to an invalid value



-ERANGE is the right error code when the value is outside of the menu
range, but -EINVAL must be reported for invalid values inside the range.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

parent 1e2e9086

drivers/media/usb/uvc/uvc_ctrl.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1487,7 +1487,7 @@ int uvc_ctrl_set(struct uvc_video_chain *chain,
		step = mapping->get(mapping, UVC_GET_RES,
		uvc_ctrl_data(ctrl, UVC_CTRL_DATA_RES));
		if (!(step & value))
		return -ERANGE;
		return -EINVAL;
		}

		break;