Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b3ed6c63 authored by Johan Hedberg's avatar Johan Hedberg Committed by Marcel Holtmann
Browse files

Bluetooth: Remove unnecessary l2cap_chan_unlock before l2cap_chan_add 



The l2cap_chan_add() function doesn't require the channel to be
unlocked. It only requires the l2cap_conn to be unlocked. Therefore,
it's unnecessary to unlock a channel before calling l2cap_chan_add().
This patch removes such unnecessary unlocking from the
l2cap_chan_connect() function.

Signed-off-by: default avatarJohan Hedberg <johan.hedberg@intel.com>
Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
parent 72c6fb91

net/bluetooth/l2cap_core.c

+0 −2
Original line number Diff line number Diff line
@@ -7078,9 +7078,7 @@ int l2cap_chan_connect(struct l2cap_chan *chan, __le16 psm, u16 cid, 
	bacpy(&chan->src, &hcon->src);

	chan->src_type = bdaddr_type(hcon, hcon->src_type);



	l2cap_chan_unlock(chan);

	l2cap_chan_add(conn, chan);

	l2cap_chan_lock(chan);



	/* l2cap_chan_add takes its own ref so we can drop this one */

	hci_conn_drop(hcon);