Commit b28e545c authored Jun 06, 2013 by Nicholas Bellinger

target: Drop unnecessary t_state_lock access for SCF_SUPPORTED_SAM_OPCODE assignment



This patch drops the se_cmd->t_state_lock access around SCF_SUPPORTED_SAM_OPCODE
assignment within target_setup_cmd_from_cdb().

Original v4.0 target code required this as fabrics would be checking for
this values in different process contexts for setup and I/O submission.

Given that modern v4.1 target code performs setup and I/O submission
from the same process context, this t_state_lock access is no longer
required.

Cc: Christoph Hellwig <hch@lst.de>
Cc: Roland Dreier <roland@kernel.org>
Cc: Kent Overstreet <koverstreet@google.com>
Cc: Or Gerlitz <ogerlitz@mellanox.com>
Cc: Moussa Ba <moussaba@micron.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>

parent 1a398b97

drivers/target/target_core_transport.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -1089,7 +1089,6 @@ sense_reason_t
		target_setup_cmd_from_cdb(struct se_cmd cmd, unsigned char cdb)
		{
		struct se_device *dev = cmd->se_dev;
		unsigned long flags;
		sense_reason_t ret;

		/*
		@@ -1149,9 +1148,7 @@ target_setup_cmd_from_cdb(struct se_cmd cmd, unsigned char cdb)
		if (ret)
		return ret;

		spin_lock_irqsave(&cmd->t_state_lock, flags);
		cmd->se_cmd_flags \|= SCF_SUPPORTED_SAM_OPCODE;
		spin_unlock_irqrestore(&cmd->t_state_lock, flags);

		spin_lock(&cmd->se_lun->lun_sep_lock);
		if (cmd->se_lun->lun_sep)