Commit b26384dc authored Mar 25, 2015 by Eric Sandeen Committed by Dave Chinner Mar 25, 2015

xfs: fix NULL pointer dereference in xfs_filestream_lookup_ag()



If xfs_filestream_get_parent() fails, we have a null pip,
goto out, and attempt to IRELE(NULL).  This causes a null
pointer dereference and BUG().

Fix this by directly returning NULLAGNUMBER in this case.

Reported-by: Adrien Nader <adrien@notk.org>
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>

parent d64588ca

fs/xfs/xfs_filestream.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -322,7 +322,7 @@ xfs_filestream_lookup_ag(

	pip = xfs_filestream_get_parent(ip);		pip = xfs_filestream_get_parent(ip);
	if (!pip)		if (!pip)
	goto out;		return NULLAGNUMBER;

	mru = xfs_mru_cache_lookup(mp->m_filestream, pip->i_ino);		mru = xfs_mru_cache_lookup(mp->m_filestream, pip->i_ino);
	if (mru) {		if (mru) {