Commit b24b1033 authored Jul 27, 2005 by Alan Stern Committed by Linus Torvalds Jul 27, 2005

[PATCH] scsi_scan: check return code from scsi_sysfs_add_sdev



Adds a missing check for an error return code from scsi_sysfs_add_sdev.
This resolves entry #4863 in the OSDL bugzilla.  Although in that bug
report the failure occurred because of a confusion over scanning vs.
rescanning, in general add_sdev can fail for a number of reasons (the
simplest being insufficient memory) and the caller should cope properly.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Cc: James Bottomley <James.Bottomley@SteelEye.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent 104e49fc

drivers/scsi/scsi_scan.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -756,7 +756,8 @@ static int scsi_add_lun(struct scsi_device sdev, char inq_result, int *bflags)
		* register it and tell the rest of the kernel
		* about it.
		*/
		scsi_sysfs_add_sdev(sdev);
		if (scsi_sysfs_add_sdev(sdev) != 0)
		return SCSI_SCAN_NO_RESPONSE;

		return SCSI_SCAN_LUN_PRESENT;
		}