Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b2057629 authored by Philipp Reisner's avatar Philipp Reisner
Browse files

drbd: Hold a reference to ldev while doing meta-data IO 



Signed-off-by: default avatarPhilipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: default avatarLars Ellenberg <lars.ellenberg@linbit.com>
parent 4a2fe568

drivers/block/drbd/drbd_actlog.c

+6 −0
Original line number Diff line number Diff line
@@ -118,6 +118,12 @@ static int _drbd_md_sync_page_io(struct drbd_conf *mdev, 
	bio->bi_end_io = drbd_md_io_complete;

	bio->bi_rw = rw;



	if (!get_ldev_if_state(mdev, D_ATTACHING)) {  /* Corresponding put_ldev in drbd_md_io_complete() */

		dev_err(DEV, "ASSERT FAILED: get_ldev_if_state() == 1 in _drbd_md_sync_page_io()\n");

		ok = 0;

		goto out;

	}



	bio_get(bio); /* one bio_put() is in the completion handler */

	atomic_inc(&mdev->md_io_in_use); /* drbd_md_put_buffer() is in the completion handler */

	if (drbd_insert_fault(mdev, (rw & WRITE) ? DRBD_FAULT_MD_WR : DRBD_FAULT_MD_RD))

drivers/block/drbd/drbd_worker.c

+1 −0
Original line number Diff line number Diff line
@@ -81,6 +81,7 @@ void drbd_md_io_complete(struct bio *bio, int error) 
	wake_up(&mdev->misc_wait);

	bio_put(bio);

	drbd_md_put_buffer(mdev);

	put_ldev(mdev);

}



/* reads on behalf of the partner,