Commit b0dd00ad authored Apr 03, 2015 by Michael Ellerman

powerpc/cell: Fix crash in iic_setup_cpu() after per_cpu changes



The conversion from __get_cpu_var() to this_cpu_ptr() in iic_setup_cpu()
is wrong. It causes an oops at boot.

We need the per-cpu address of struct cpu_iic, not cpu_iic.regs->prio.

Sparse noticed this, because we pass a non-iomem pointer to out_be64(),
but we obviously don't check the sparse results often enough.

Fixes: 69111bac ("powerpc: Replace __get_cpu_var uses")
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

parent 7e862d7e

arch/powerpc/platforms/cell/interrupt.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -163,7 +163,7 @@ static unsigned int iic_get_irq(void)

		void iic_setup_cpu(void)
		{
		out_be64(this_cpu_ptr(&cpu_iic.regs->prio), 0xff);
		out_be64(&this_cpu_ptr(&cpu_iic)->regs->prio, 0xff);
		}

		u8 iic_get_target_id(int cpu)