Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b0cfb794 authored by Andreas Bosch's avatar Andreas Bosch Committed by Dmitry Torokhov
Browse files

Input: alps - fix v4 button press recognition 

Since the change to struct input_mt_pos some variables are now bitfields
instead of integers. Automatic conversion from integer to bitfield entry
destroys information, therefore enforce boolean interpretation instead.

Link: https://bugzilla.redhat.com/show_bug.cgi?id=1114768


Fixes: 02d04254 ("Input: alps - use struct input_mt_pos to track coordinates")
Signed-off-by: default avatarAndreas Bosch <linux@progandy.de>
Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent 4af6600f

drivers/input/mouse/alps.c

+2 −2
Original line number Diff line number Diff line
@@ -835,8 +835,8 @@ static void alps_process_packet_v4(struct psmouse *psmouse) 
		f->fingers = alps_process_bitmap(priv, f);

	}



	f->left = packet[4] & 0x01;

	f->right = packet[4] & 0x02;

	f->left = !!(packet[4] & 0x01);

	f->right = !!(packet[4] & 0x02);



	f->st.x = ((packet[1] & 0x7f) << 4) | ((packet[3] & 0x30) >> 2) |

		  ((packet[0] & 0x30) >> 4);